Open
Conversation
…et by _connection_layer on load
Owner
|
Thanks so much for figuring out what was causing this issue! I'm going to be starting up development on this plugin again, so I'll probably implement a similar fix and submit everything to the asset library soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Godot 4.3 had seen a big change with GraphEdits and GraphNodes, and as part of that, a new node has been introduced, but since it's not marked as internal, it will also return in
GetChildren(), resulting in the important node being deleted, and subsequently attempting to write to invalid memory space, causing Godot to crash via a SIGSEGV signal.This will fix issue #6 by providing the following workaround:
DialogueGraph.ClearTree(), filter out_connection_layer_connection_layerThis has been tested with Start/Switch/Output Dialogue nodes, but not tested further with other nodes, and regression may be introduced in certain use cases.